Conversation
The writeread test was producing wildly inconsistent results on windows. Problem turned out to be the allocation of the counts array, which by some stroke of luck seems to always get a buffer full of zeros on most platforms...except for windows which more frequently gets whatever garbage is on the heap at the allocated location. This in turn leads to count values that start at some huge number and goes up from there, leading to 0 average per call run time results. Allocate the array with zalloc to ensure 0 count values at the start of the test. Fixes #56
nhorman
requested review from
Sashan,
andrewkdinh,
esyr,
jogme,
mattcaswell,
npajkovsky and
t8m
esyr
approved these changes
Oct 21, 2025
andrewkdinh
approved these changes
Oct 21, 2025
jogme
approved these changes
Oct 22, 2025
t-j-h
approved these changes
Oct 22, 2025
Sashan
approved these changes
Oct 22, 2025
Sashan
left a comment
Sashan
left a comment
Contributor
There was a problem hiding this comment.
nice. looks good to me thanks.
Sashan
pushed a commit
that referenced
this pull request
Oct 22, 2025
The writeread test was producing wildly inconsistent results on windows. Problem turned out to be the allocation of the counts array, which by some stroke of luck seems to always get a buffer full of zeros on most platforms...except for windows which more frequently gets whatever garbage is on the heap at the allocated location. This in turn leads to count values that start at some huge number and goes up from there, leading to 0 average per call run time results. Allocate the array with zalloc to ensure 0 count values at the start of the test. Fixes #56 Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Saša Nedvědický <sashan@openssl.org> (Merged from #59)
Contributor
|
fixed via b7ec458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writeread test was producing wildly inconsistent results on windows.
Problem turned out to be the allocation of the counts array, which by some stroke of luck seems to always get a buffer full of zeros on most platforms...except for windows which more frequently gets whatever garbage is on the heap at the allocated location. This in turn leads to count values that start at some huge number and goes up from there, leading to 0 average per call run time results.
Allocate the array with zalloc to ensure 0 count values at the start of the test.
Fixes #56